Skip to content

Add support for 128-bit integer scalars #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

jturner314
Copy link
Member

Rust 1.26 adds i128 and u128 primitive types.

I've added a note in the changelog about this. Should the new version be 0.11.3 or 0.12.0?

@jturner314
Copy link
Member Author

I just pushed a new version of this PR that specifies the new version as 0.12.0 in the changelog. I realized that since we say "Requires Rust 1.22" in the documentation, it makes more sense for a bump in the required Rust version to be a breaking change.

Fwiw, it would be possible to use conditional compilation to avoid breaking on older compilers, but IMO it's not worth the extra complication unless someone has a specific use-case.

One other thought – it may make sense to wait for Rust 1.27 before releasing a breaking change, because stable SIMD is planned for that version.

Rust 1.26 adds `i128` and `u128` primitive types.
@jturner314 jturner314 merged commit a62fe26 into rust-ndarray:master Jun 13, 2018
@jturner314 jturner314 deleted the int128 branch June 13, 2018 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant