Update ndarray-rand to rand 0.5.0 #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilgoyette
reviewed
May 24, 2018
ndarray-rand/src/lib.rs
Outdated
| Sh: ShapeBuilder<Dim=D>, | ||
| { | ||
| Self::random_using(shape, dist, &mut rand::weak_rng()) | ||
| let mut rng = SmallRng::from_rng(thread_rng()) | ||
| .unwrap_or_else(|err| panic!("create SmallRng from thread_rng failed: {:?}", err)); |
There was a problem hiding this comment.
Isn't this the same as expect("create SmallRng from thread_rng failed")? The way I understand the documentation, I believe it is equivalent. If so, I think we should prefer expect.
There was a problem hiding this comment.
Yes, you're right. I just made that change. Thanks.
|
No one has objected to this PR, so I've merged it. |
|
By the way, @nilgoyette thanks for reviewing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to replicate the old behavior as closely as possible.
This PR removes support for
SampleandIndependentSample, which are deprecated inrand 0.5.0, and replaces them with the newDistributiontrait.Fixes #455.