Skip to content

Bump num-traits, num-complex #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2018
Merged

Bump num-traits, num-complex #458

merged 1 commit into from
Jun 13, 2018

Conversation

alexbool
Copy link
Contributor

This is a breaking change since num-complex is a part of ndarray's a public API

jturner314
jturner314 approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@jturner314 jturner314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

@bluss Do you have any comments?

@termoshtt termoshtt mentioned this pull request May 30, 2018
Merged
2 tasks
@alexbool
Copy link
Contributor Author

@bluss friendly ping

@jturner314 jturner314 merged commit 04b92e0 into rust-ndarray:master Jun 13, 2018
@jturner314
Copy link
Member

I haven't heard from @bluss in quite a while, so I'm going ahead and merging this.

Thanks @alexbool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner314 jturner314 jturner314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbool @jturner314