ci: Use cargo xtask fmt --check
#1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-fmt
branch
from
6168941 to
e5d5d50
Compare
phip1611
reviewed
Aug 24, 2024
| run: | | ||
| rustup component add rustfmt | ||
| cargo fmt --all -- --check | ||
| curl -L --fail --output /tmp/yamlfmt.tar.xz https://github.com/google/yamlfmt/releases/download/v${YFV}/yamlfmt_${YFV}_Linux_x86_64.tar.gz |
There was a problem hiding this comment.
nit: If we add nix, this could be a simple nix-shell --run "cargo xtask fmt --check". Similar to here https://github.com/rust-osdev/uefi-rs/blob/main/.github/workflows/developer_productivity.yml#L50
There was a problem hiding this comment.
Makes sense, but looks like a bit of additional work is needed since the nix files currently fail the format check, and also https://github.com/nix-community/nixpkgs-fmt has been deprecated. I'll go ahead and merge the version without nix, and we can follow up with another PR later.
There was a problem hiding this comment.
Ohh.. I had no clue that it is deprecated (to be fair, only since very recently) . Thanks!
phip1611
approved these changes
Aug 24, 2024
nicholasbishop
force-pushed
the
bishop-fmt
branch
3 times, most recently
from
4ffcc24 to
e5d5d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1198
Checklist