better CStr16 to String and str #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
better-cstr16-to-string
branch
from
4c40dd0 to
e4d8598
Compare
phip1611
force-pushed
the
better-cstr16-to-string
branch
from
e4d8598 to
256c884
Compare
|
hey @GabrielMajeri |
phip1611
force-pushed
the
better-cstr16-to-string
branch
from
f86fb4d to
f011be4
Compare
phip1611
force-pushed
the
better-cstr16-to-string
branch
from
f011be4 to
9bf8b66
Compare
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience, the current CStr16 abstraction is really a pain when you want to use the strings in regular Rust code. As I'm developing my own OS/kernel, I'd love to have a nice way to transform these to regular Rust strings.