Skip to content

Fix doc link and make CI lints stricter #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 23, 2021

Conversation

nicholasbishop
Copy link
Member

@nicholasbishop nicholasbishop commented Aug 19, 2021

  • Fix a doc link that rustdoc doesn't understand
  • Add a cargo doc step to the CI to catch things like that automatically
  • Also changed the clippy lint to treat warnings as errors
  • Enable more of the crate's features in tests

This can catch some issues like broken links in docstrings.
This makes the CI actually fail instead of just putting warning
annotations in the source.
For clippy and rustdoc, add `--all-features` to cover more code.

For `cargo test`, enable just the `exts` feature (the `alloc` and
`logger` features can't be enabled because we're not running under UEFI
here).
@GabrielMajeri
Copy link
Collaborator

GabrielMajeri commented Aug 23, 2021

The changes look good. Thanks for improving the CI pipeline!

@GabrielMajeri GabrielMajeri merged commit 93c2991 into rust-osdev:master Aug 23, 2021
@nicholasbishop nicholasbishop deleted the bishop-test-doc branch December 12, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants