Handle UEFI warnings more cleanly #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielMajeri
approved these changes
Oct 13, 2018
There was a problem hiding this comment.
There are some things which could be debated but I can't see a more ergonomic solution for now.
The whole design of UEFI's "extensible" warning / error codes pretty much breaks the point of listing the possible error values in the first place 😞 I don't think there's any other way of making error handling convenient and safe in this case.
|
The latest commit is an experiment towards improving the ergonomics of the |
HadrienG2
changed the title
|
Alright, the version with the ResultExt extension trait starts to feel like something I could get behind. Feel like taking a second look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UEFI has warnings, which represent non-fatal errors. Currently, we treat them as fatal errors, which is somewhat pessimistic. This PR explores a different strategy which allows the user to do various things with warnings including pattern-matching them, logging them silently, or handling them as errors.
Some errors which were previously discarded, such as
EFI_TIMEOUTin serial communication, are now reported as warnings.Fixes #52.