Properly handle allocation failure #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in rust-osdev#89 did not properly handle allocation failures. On failure, alloc() returns a null pointer, and this is not checked. This change moves buffer allocation to the new Alloc API, correctly handles allocation failure, and avoids potential unsafety with zero-sized alloc requests. I also removed the dependancy on uefi-services from uefi-alloc. The dependancy isn't needed, and now users can use uefi-exts with their own allocators.
josephlr
force-pushed
the
master
branch
2 times, most recently
from
471a46a to
4adedd6
Compare
|
Looks like a great change, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #89 did not properly handle allocation failures. On
failure,
alloc()returns a null pointer, and this is not checked.This change moves buffer allocation to the new Alloc API, and correctly
handles allocation failure and potential unsafety with zero-sized alloc
requests.
I also removed the dependency on
uefi-servicesfromuefi-alloc. Thedependency isn't needed, and now users can use
uefi-extswith theirown allocators.