Skip to content

Expose NodeId directly and safely #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Expose NodeId directly and safely #13

merged 1 commit into from
Apr 23, 2018

Conversation

causal-agent
Copy link
Collaborator

Intended to address #12 cc @RazrFalcon

  • Exposes internal IDs directly as NodeId (with private field)
  • Provides get methods returning Option and unsafe get_unchecked methods
  • Panics in NodeMut methods if given NodeId is not valid
  • Exposes NodeRef and NodeMut id and tree fields publicly

@RazrFalcon
Copy link
Contributor

Looks good.

@causal-agent causal-agent merged commit 8115ab1 into master Apr 23, 2018
@causal-agent causal-agent deleted the safe-node-id branch April 23, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants