Use NonZeroUsize inside NodeId #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
Option<NodeId>
to be no larger thanusize
, and saves 32 bytes of memory per node.To allow IDs to be used directly as indexes, the
Vec<Node<T>>
storage has an uninitialized item at index 0. Safety-wise, this "infects" the entire crate: every access to thisVec
needs to make sure to skip that first (non-)item.