Skip to content

Expose and fix all ImageCapture APIs #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dodomorandi opened this issue Nov 6, 2020 · 1 comment · Fixed by #2348
Closed

Expose and fix all ImageCapture APIs #2347

dodomorandi opened this issue Nov 6, 2020 · 1 comment · Fixed by #2348
Labels

Comments

@dodomorandi
Copy link
Contributor

dodomorandi commented Nov 6, 2020

Describe the Bug

Not all ImageCapture API are exposed, maybe it is just because of Gecko not currently supporting some of them. The webidl contains some (maybe obsolete?) API that are different from the current working draft.

Steps to Reproduce

Open ImageCapture.webidl to notice some attributes and methods are commented out. Compare them with the official specification to notice some differences.

Expected Behavior

These features should be fixed and exposed in order to make them usable in web-sys, even if the implementation in Gecko is lacking.

Actual Behavior

The fact that some features are commented out make them unavailable in web-sys, which a bit painful because using extension traits is not doable when wasm_bindgen is involved -- if there is some workaround for this other than using a newtype, let me know. Obviously, having them available but not correctly implemented is bad as well.

@dodomorandi dodomorandi added the bug label Nov 6, 2020
@dodomorandi dodomorandi changed the title Expose all ImageCapture APIs Expose and fix all ImageCapture APIs Nov 6, 2020
@alexcrichton
Copy link
Contributor

This may have been done in the very early days of web-sys as well when many types weren't supported, but should be fine to update the WebIDL or uncomment it now!

dodomorandi added a commit to dodomorandi/wasm-bindgen that referenced this issue Nov 6, 2020
alexcrichton pushed a commit that referenced this issue Nov 9, 2020
* Fix ImageCapture API (#2347)

* Move ImageCapture to unstable webidls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants