Add TypedArray::copy_from #2492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
TypedArray::copy_from(src)
, as the dual ofTypedArray::copy_to(dst)
.While this can already be achieved today with
TypedArray::set()
, it requires either unsafe code or an additional allocation:The new helper method provides a safe interface to perform this copy:
Internally, it uses the unsafe implementation listed above. We know that this is safe, because:
TypedArray
view on the Rust slice lives only for the duration of thecopy_from()
callset()
does not grow the WebAssembly linear memory, so it cannot invalidate the created view