Skip to content

Implement Extend<A> for Array where A: AsRef<JsValue> #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

Implement Extend<A> for Array where A: AsRef<JsValue> #2681

merged 1 commit into from
Sep 15, 2021

Conversation

arnauorriols
Copy link
Contributor

Collections are conventionally expected to implement both FromInterator and Extend traits. More specifically, I need Array to implement Extend in order to build one with futures::StreamExt::collect()

@arnauorriols arnauorriols force-pushed the implement-extend-jsvalue-for-array branch from a08eac5 to 833f7f7 Compare September 14, 2021 23:43
@arnauorriols arnauorriols force-pushed the implement-extend-jsvalue-for-array branch from 833f7f7 to 2ac80f1 Compare September 15, 2021 06:15
@alexcrichton alexcrichton merged commit 9fa0ab9 into rustwasm:master Sep 15, 2021
@alexcrichton
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnauorriols @alexcrichton