Skip to content

Array iterator method bindings #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2018
Merged

Array iterator method bindings #289

merged 2 commits into from
Jun 21, 2018

Conversation

wismer
Copy link
Contributor

@wismer wismer commented Jun 21, 2018

I wanted to do values as well, but I guess there's not a TS def for it? Fails tests, not a function.

fitzgen
fitzgen approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @wismer :)

@fitzgen fitzgen merged commit 9e01e67 into rustwasm:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wismer @fitzgen