Attribute for static methods #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohanar
approved these changes
Jun 23, 2018
crates/backend/src/ast.rs
Outdated
| leading_colon: None, | ||
| segments, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This logic largely redundant with wasm_bindgen_webidl::util::ident_ty, it might be good to move some of the utility functions out of that crate and into the backend.
|
Looks good to me. I'll let you decide if you want to address the small amount of refactoring here or leave it for the future. |
This is similar to `js_namespace` but translates into a static method on `Class` rather than a free function. This allows us to have bindings to things like `Object.keys` as `Object::keys`.
fitzgen
force-pushed
the
attribute-for-static-methods
branch
from
d7d59fd to
8fbf478
Compare
|
FWIW this was sort of the intention of |
|
Yes, I can do that when I get a chance. The reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hooks up the existing support for static methods that @ohanar added for WebIDL to a
#[wasm_bindgen(static_method_of = Class)]attribute, and implements bindings toObject.keysto exercise the code path during tests.