Adds valueOf and toString to Number #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-s
commented
Jun 23, 2018
| let number = 1234.45; | ||
| assert.equal(wasm.to_locale_string(number, "de-DE"), "1,234.45"); | ||
| assert.equal(wasm.to_locale_string(number, "en-US"), "1,234.45"); | ||
| assert.equal(wasm.to_locale_string(number, "zh-Hans-CN-u-nu-hanidec"), "1,234.45"); |
There was a problem hiding this comment.
If you use this locale string for javascript in the browser you'll get chinese characters. Any idea why that doesn't work here?
There was a problem hiding this comment.
I assume it must be an issue with node.js then.
There was a problem hiding this comment.
This test fails for me, I get the chinese characters. Also the "de-DE" fails for me, I get "1.234,45".
There was a problem hiding this comment.
Hm, I wonder if it depends on some other system-specific things then. Perhaps we should just disable the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing this I saw that
Result<String, JsValue>can't cross the javascript boundary. As it isn't described in wasmdescribe. Would it be desirable to ever have that described in wasmdescribe, or should you explicitly handle any errors in Rust code.