Adds Number to_fixed and to_exponential function #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-s
approved these changes
Jun 24, 2018
ohanar
reviewed
Jun 24, 2018
src/js.rs
Outdated
| /// | ||
| /// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed | ||
| #[wasm_bindgen(catch, method, js_name = toFixed)] | ||
| pub fn to_fixed(this: &Number, digits: u8) -> Result<String, JsValue>; |
There was a problem hiding this comment.
Please return JsStrings rather than Strings. Returning Strings forces us to copy into wasm memory every time a method is called. I just merged a pull request that makes it easy to convert to and from JsString and String, you might want to merged that to make it easier to write tests.
There was a problem hiding this comment.
Ah the new change. Done 👍
|
Thanks @sendilkumarn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.