String.prototype.substr() support
#307
Conversation
src/js.rs
Outdated
| /// the start index and a number of characters after it. | ||
| /// | ||
| /// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr | ||
| /// TODO: Add `NaN` and `undefined` support |
There was a problem hiding this comment.
Added todo as we don't yet have that support(or at least not that I know of).
There was a problem hiding this comment.
The NaN behavior is on the JS engine implementation side, not our side, so we don't need to worry about it.
| assert.equal(wasm.create_substr(aString, -1, 1), "a"); | ||
| assert.equal(wasm.create_substr(aString, 1, -1), ""); | ||
| // TODO: Uncomment and test these assertions, once we have support for optional parameters | ||
| // assert.equal(wasm.create_substr(aString, -3), "lla"); |
There was a problem hiding this comment.
I did add those tests though(for the optional parameter) and do want to know what should be added as a todo if needed at all.
src/js.rs
Outdated
| /// the start index and a number of characters after it. | ||
| /// | ||
| /// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr | ||
| /// TODO: Add `NaN` and `undefined` support |
There was a problem hiding this comment.
The NaN behavior is on the JS engine implementation side, not our side, so we don't need to worry about it.
|
Should I remove the todos then? And how should we handle the Optional parameters - again with todos or you want another way of doing it? |
|
For optional parameters, it is often best to just require their presence. It is a judgement call on a case-to-case basis though. |
|
I removed the TODO, don't know if I should leave the |
I wanted to open this PR as well as ask some questions. Not sure how the whole binding works, but I do know some stuff currently are not supported as the optional parameters( as well as
NaNsupport). But I also wanted to raise the question:What about all the special cases for specific handling?, for example I can givesubstr:How can these cases be handled as a whole and what should we do about them until we can actually handle them?