Array.prototype.filter #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
seako
pushed a commit
to seako/wasm-bindgen
that referenced
this pull request
Jun 28, 2018
following the example set in rustwasm#314
alexcrichton
pushed a commit
that referenced
this pull request
Jun 28, 2018
following the example set in #314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key to making the higher order functions like
Array.prototype.filterwork, is to not take values by reference in the closure. That is a little too tricky for the macros insrc/{convert,describe}.rsand is also unnecessary since these things are all indices into a table under the hood anyways -- not something that is too big to efficiently pass directly.