Test release builds on Travis #393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling locally shows a 3x speed improvement by testing release builds, presumably due to the amount of wasm processing happening! Let's see what happens on Travis and if we get a similar speedup.
|
Looks like 17 minutes compared to 15 minutes, so not as big of a gain on Travis! |
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this pull request
Jul 9, 2018
This is similar to rustwasm#393 but I'm also curious what the effect of the number of test threads has...
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this pull request
Jul 9, 2018
This is similar to rustwasm#393 but I'm also curious what the effect of the number of test threads has...
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this pull request
Jul 9, 2018
Contrary to rustwasm#393 it looks like it's a big win now with the number of tests we have. Tested in rustwasm#429 it was confirmed that multiple threads are indeed benefitting us here. A [debug build][1] took 22m while a [release build][2] took 15m. [1]: https://travis-ci.org/rustwasm/wasm-bindgen/jobs/401819002 [2]: https://travis-ci.org/rustwasm/wasm-bindgen/jobs/401819004
alexcrichton
added a commit
that referenced
this pull request
Jul 9, 2018
Contrary to #393 it looks like it's a big win now with the number of tests we have. Tested in #429 it was confirmed that multiple threads are indeed benefitting us here. A [debug build][1] took 22m while a [release build][2] took 15m. [1]: https://travis-ci.org/rustwasm/wasm-bindgen/jobs/401819002 [2]: https://travis-ci.org/rustwasm/wasm-bindgen/jobs/401819004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling locally shows a 3x speed improvement by testing release builds,
presumably due to the amount of wasm processing happening! Let's see what
happens on Travis and if we get a similar speedup.