Test no_std MSRV in CI
#4292
Merged
Test no_std MSRV in CI
#4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
msrv-ci
branch
5 times, most recently
from
0d0ee01 to
45cd941
Compare
They are tested transitively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't test the MSRV of
no_stdfor our libraries in the CI. Accidentally, I noticed that we didn't test our crates with the right target as well.This PR adds tests for both, native and Wasm, and
no_stdto the CI.EDIT: right on the nose, I promptly found two bugs that I fixed.