Skip to content

Binding for Array.prototype.map() #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Binding for Array.prototype.map() #453

merged 1 commit into from
Jul 10, 2018

Conversation

dorayakikun
Copy link
Contributor

This is my first PR.
Could you review it?

Referencing issue #275.

Thank you.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Need to check on why CI is failing

@fitzgen
Copy link
Member

fitzgen commented Jul 10, 2018

I think this is jsut intermittent infra issues causing the CI failure -- restarted that job and we will see what happens!

Thanks again @dorayakikun !

@fitzgen fitzgen merged commit 94d939f into rustwasm:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants