Create basic WebGL example #835
Conversation
examples/webgl/src/lib.rs
Outdated
| source: &str, | ||
| ) -> Result<WebGlShader, String> { | ||
| let shader = context | ||
| .create_shader(shader_type as u32) |
There was a problem hiding this comment.
incredibly, incredibly minor - but it seems like shader_type is already a u32 so need for casting?
examples/webgl/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[wasm_bindgen] |
There was a problem hiding this comment.
Minor - but what about moving this function to the top of the file since it's the meat of the demo?
There was a problem hiding this comment.
Looking good, thanks!
In addition to the nitpicks that @chinedufn pointed out, could you also add a subsection to the guide that shows off this example, similar to guide/src/web-sys/examples/*. Make sure to also add the new section to guide/src/SUMMARY.md or else it won't show up.
Thanks a bunch!
blm768
force-pushed
the
webgl-example
branch
from
6a56d3d to
3d9f102
Compare
blm768
force-pushed
the
webgl-example
branch
from
3d9f102 to
426671d
Compare
|
@chinedufn Good catch on the cast. That's what I get for copying from my other project. ;) I think I've got the guide section in, but let me know if something doesn't look right. |
This example doesn't do much, but it gets a triangle on the screen.