Skip to content

Uncommented some WebIDL TODO #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions crates/web-sys/webidls/enabled/Document.webidl
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ interface nsISupports;
interface URI;
interface nsIDocShell;
interface nsILoadGroup;
*/

enum VisibilityState { "hidden", "visible" };
*/

/* https://dom.spec.whatwg.org/#dictdef-elementcreationoptions */
dictionary ElementCreationOptions {
Expand All @@ -35,11 +35,8 @@ dictionary ElementCreationOptions {
/* https://dom.spec.whatwg.org/#interface-document */
[Constructor]
interface Document : Node {

/*TODO
[Throws]
readonly attribute DOMImplementation implementation;
*/
[Pure, Throws, BinaryName="documentURIFromJS", NeedsCallerType]
readonly attribute DOMString URL;
[Pure, Throws, BinaryName="documentURIFromJS", NeedsCallerType]
Expand Down Expand Up @@ -79,10 +76,8 @@ interface Document : Node {
Text createTextNode(DOMString data);
[NewObject]
Comment createComment(DOMString data);
/*TODO
[NewObject, Throws]
ProcessingInstruction createProcessingInstruction(DOMString target, DOMString data);
*/

[CEReactions, Throws]
Node importNode(Node node, optional boolean deep = false);
Expand All @@ -92,10 +87,8 @@ interface Document : Node {
[NewObject, Throws, NeedsCallerType]
Event createEvent(DOMString interface);

/*TODO
[NewObject, Throws]
Range createRange();
*/

// NodeFilter.SHOW_ALL = 0xFFFFFFFF
[NewObject, Throws]
Expand All @@ -110,26 +103,22 @@ interface Document : Node {

// These are not in the spec, but leave them for now for backwards compat.
// So sort of like Gecko extensions
/*TODO
[NewObject, Throws]
CDATASection createCDATASection(DOMString data);
[NewObject, Throws]
Attr createAttribute(DOMString name);
[NewObject, Throws]
Attr createAttributeNS(DOMString? namespace, DOMString name);
*/
};

// https://html.spec.whatwg.org/multipage/dom.html#the-document-object
partial interface Document {
/*TODO
[PutForwards=href, Unforgeable] readonly attribute Location? location;
//(HTML only) attribute DOMString domain;
readonly attribute DOMString referrer;
//(HTML only) attribute DOMString cookie;
readonly attribute DOMString lastModified;
readonly attribute DOMString readyState;
*/

// DOM tree accessors
//(Not proxy yet)getter object (DOMString name);
Expand Down Expand Up @@ -305,11 +294,8 @@ partial interface Document {
// https://w3c.github.io/page-visibility/#extensions-to-the-document-interface
partial interface Document {
readonly attribute boolean hidden;

/*TODO
readonly attribute VisibilityState visibilityState;
attribute EventHandler onvisibilitychange;
*/
};

// https://drafts.csswg.org/cssom/#extensions-to-the-document-interface
Expand Down Expand Up @@ -402,10 +388,8 @@ partial interface Document {

// http://w3c.github.io/selection-api/#extensions-to-document-interface
partial interface Document {
/*TODO
[Throws]
Selection? getSelection();
*/
};

// Extension to give chrome JS the ability to determine whether
Expand Down
2 changes: 0 additions & 2 deletions crates/web-sys/webidls/enabled/Element.webidl
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@ interface Element : Node {
attribute DOMString id;
[CEReactions, Pure]
attribute DOMString className;
/*TODO
[Constant, PutForwards=value]
readonly attribute DOMTokenList classList;
*/

[SameObject]
readonly attribute NamedNodeMap attributes;
Expand Down
4 changes: 0 additions & 4 deletions crates/web-sys/webidls/enabled/Node.webidl
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,8 @@ interface Node : EventTarget {
readonly attribute boolean isConnected;
[Pure]
readonly attribute Document? ownerDocument;
/*TODO
[Pure]
Node getRootNode(optional GetRootNodeOptions options);
*/
[Pure]
readonly attribute Node? parentNode;
[Pure]
Expand Down Expand Up @@ -103,8 +101,6 @@ interface Node : EventTarget {
boolean isDefaultNamespace(DOMString? namespace);
};

/*TODO
dictionary GetRootNodeOptions {
boolean composed = false;
};
*/