Remove Module node from the backend AST
#846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a roundabout way to say that this addresses the last comment on rustwasm#23, namely if you only use the `console` submodule from `web_sys` it doesn't actually link correctly! The problem here has to do with codegen units and the compiler. The compiler will create a codegen unit for each `mod` in the source code. If a codegen unit isn't actually used, then the codegen unit is removed from the final link step. This causes problems for web-sys where the JSON description of our program was part of the main CGU but not in each submodule, so when submodules were only used the descriptor program in the main CGU was not included. The fix in this commit is to instead generate a descriptor program in the submodule itself instead of leaving it in the main CGU. By removing the `Module` node in the AST this naturally happens as the descriptor is only generated in the same module as all other associated items.
fitzgen
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a roundabout way to say that this addresses the last comment on #23,
namely if you only use the
consolesubmodule fromweb_sysit doesn'tactually link correctly!
The problem here has to do with codegen units and the compiler. The compiler
will create a codegen unit for each
modin the source code. If a codegen unitisn't actually used, then the codegen unit is removed from the final link step.
This causes problems for web-sys where the JSON description of our program was
part of the main CGU but not in each submodule, so when submodules were only
used the descriptor program in the main CGU was not included.
The fix in this commit is to instead generate a descriptor program in the
submodule itself instead of leaving it in the main CGU. By removing the
Modulenode in the AST this naturally happens as the descriptor is only generated in
the same module as all other associated items.