Tweak more Closure docs
#848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinedufn
reviewed
Sep 17, 2018
src/closure.rs
Outdated
| @@ -55,9 +57,9 @@ use throw; | |||
| /// pub fn run() -> ClosureHandle { | |||
| /// // First up we use `Closure::new` to wrap up a Rust closure and create | |||
There was a problem hiding this comment.
Looks like the comment needs a tweak
| /// | ||
| /// let window = web_sys::window().unwrap(); | ||
| /// window.set_timeout_with_callback_and_timeout_and_arguments_0( | ||
| /// // Note this method call, which uses `as_ref()` to get a `JsValue` |
Show off usage of the stable `Closure::wrap` instead of `Closure::new` and additionally add an explicit example of using it with `web_sys`. Closes rustwasm#843
alexcrichton
force-pushed
the
closure-docs-again
branch
from
cc9eb0a to
bb82db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show off usage of the stable
Closure::wrapinstead ofClosure::newandadditionally add an explicit example of using it with
web_sys.Closes #843