Skip to content

Fix windows support #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2015
Merged

Fix windows support #12

merged 1 commit into from
Jun 28, 2015

Conversation

tsing80
Copy link
Contributor

@tsing80 tsing80 commented Jun 28, 2015

No description provided.

@@ -4,7 +4,7 @@ module.exports = {
name: 'Ember CLI ic-ajax',

init: function(name) {
this.treePaths['vendor'] = require.resolve('ic-ajax').replace('ic-ajax/dist/cjs/main.js', '');
this.treePaths['vendor'] = require.resolve('ic-ajax').replace(require('path').join('ic-ajax','dist','cjs','main.js'), '');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split the path.join bit into a separate local variable above this?

@tsing80
Copy link
Contributor Author

tsing80 commented Jun 28, 2015

Reworked, it still does not work though for me both in windows and mac in npm 3 before and after the change

@rwjblue
Copy link
Owner

rwjblue commented Jun 28, 2015

@tsing80 - NPM 3 requires changes in ember-cli also (submitted in ember-cli/ember-cli#4349).

rwjblue added a commit that referenced this pull request Jun 28, 2015
@rwjblue rwjblue merged commit 99cba1d into rwjblue:master Jun 28, 2015
@rwjblue
Copy link
Owner

rwjblue commented Jun 28, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants