Fix too eager templater reg exp #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is fixing a simple bug that prevent the option to have two or more patterns without any spaces between them without having to add spaces inside the curly braces:
examples of pattern this PR solves:
In the current code, it doesn't works because the
genericPlaceholderPattern
is too eager and split the patterns as one element (eg:["${num}/${total}"]
instead of["${num}", "/", "${total}"]
) then it changes the first value so we get only the equivalent of${num}
if we keep my last example.And indeed, they all can be solved like this:
but let's not limiting the options of your users ? 😉
thanks in advance!