Fixes for Azure Automation module #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Schedule by setting the correct JobScheduleId; fixing exception handling for source control cmdlets; Adding logic to ExecuteCmdlet, so that when a ErrorResponseException is thrown, we check to see if ErrorResponseException.Body.Message is available. If not, we try to extracted from error message from ErrorResponseException.Response.Content, and we rethrow again using the extracted message. With this fix, the correct error message for invalid ResourceGroupName and AutomationAccountName is displayed to the user.
mirichmo
suggested changes
Aug 21, 2018
| } | ||
|
|
||
| /// The error information. | ||
| public class AzureAutomationErrorInfo |
There was a problem hiding this comment.
This is not necessary if you use AzureAutomationErrorResponseMessage
There was a problem hiding this comment.
Good point. Fixed.
| /// <summary> | ||
| /// The error response message. | ||
| /// </summary> | ||
| public class AzureAutomationErrorResponseMessage |
There was a problem hiding this comment.
How about naming it AzureAutomationErrorInfo?
There was a problem hiding this comment.
Sounds good. Fixed.
| @@ -131,29 +168,24 @@ protected bool GenerateCmdletOutput(IEnumerable<object> results) | |||
| return ret; | |||
| } | |||
|
|
|||
| private string ParseErrorMessage(string errorMessage) | |||
| // This function determines if the given value is a Json object. | |||
| private bool IsValidJsonObject(string value) | |||
There was a problem hiding this comment.
Is this really necessary? It seems like extra work. How about just attempting to parse and handling errors?
There was a problem hiding this comment.
I agree. I will go ahead and remove the code that checks if it is a valid Json. In ParseJson, if we are not able to extract the error message, we just return null.
vrdmr
approved these changes
Aug 21, 2018
mirichmo
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following fixes: