Skip to content

Allow nubbin to change position when popover flips #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

george-norris-salesforce
Copy link

@george-norris-salesforce george-norris-salesforce commented Mar 9, 2018

Fixes #1211.

Allows the nubbin to change position when a popover flips

Before

https://gyazo.com/d4a444546e61100ef2b532cd7e1eb255

After:

https://gyazo.com/d419d7f31b8bb6c628722a326a233d75

Pull Request Review checklist (do not remove)

  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at snapshot strings.
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@interactivellama
Copy link
Contributor

Ah sweet! Tell me when you want me to look at it. Looks like some lint issues are present.

@interactivellama
Copy link
Contributor

@george-norris-salesforce I've added you as a collaborator. Please see email invite. That should give you rights to assign pull requests to me when you want to.

@interactivellama
Copy link
Contributor

I went ahead and took a peak, cause I'm so excited. The non-orthogonal directions aren't showing arrows.

screen shot 2018-03-09 at 3 51 45 pm

Should look like:

screen shot 2018-03-09 at 3 52 18 pm

@george-norris-salesforce
Copy link
Author

@interactivellama Just got back from PTO, taking a look now..

@stale
Copy link

stale bot commented Jul 15, 2018

This issue has been automatically marked as stale, because it has not had recent activity. It will be closed if no further activity occurs. Maintainers are responsible for tech debt and project health. This is most likely a new components or component feature request. Please submit a pull request for or request feedback on this feature. Thank you.

@stale stale bot added the stale label Jul 15, 2018
@stale stale bot closed this Jul 22, 2018
@salesforce-cla
Copy link

Thanks for the contribution! It looks like @george-norris-salesforce is an internal user so signing the CLA is not required. However, we need to confirm this.

@stale stale bot removed the stale label Jul 23, 2018
@interactivellama
Copy link
Contributor

interactivellama commented Jul 25, 2018

Closing. @vintik has worked this into #1404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants