Switch xml2json to xml2js in tooling #1381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional description
So this is related to (but not the final fix for) #1366 . Typically Windows users will not have python and a g++ compiler tool chain installed in order to compile native addons. A lot of modules work-around this issue by offering pre-compiled addons (like node-sass), but
node-expat
(a dependency ofxml2json
) does not.Since this is just in some tooling and I was able to use the popular
xml2js
to fill in with the same functionality, I thought this may be another way to help improve the Windows contributor experience.Pull Request Review checklist (do not remove)
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.