Improve Storyshots tests experience #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPM scripts update “build-storybook" -> static:build “build-storybook-for-tests” -> storyshots:build “storybook” -> static:start snapshot-test now includes a static build to compare to Jest image snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run build-storybook-for-testswas never being run, so the image comparison was not up to date with pull requests that contain image snapshots in our CI.NPM scripts update
“build-storybook" -> static:build
“build-storybook-for-tests” -> storyshots:build
“storybook” -> static:start
Adds new script
storyshots:startthat allows interactive viewing of what is being tested with image snapshots to allow debugging.npm run snapshot-testnow includes a static build to compare to Jest image snapshotsThis pull request only contains tooling changes.