Skip to content

Remove compact prop from DataTable #1189 #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2018

Conversation

dennismphil
Copy link
Contributor

Fixes #1189

Additional description


Pull Request Review checklist (do not remove)

  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify if the committer(s), Dennis Mathew Philip <d***@s***.com>, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@interactivellama interactivellama self-requested a review May 17, 2018 21:45
@interactivellama interactivellama merged commit b9a0b71 into salesforce:master May 17, 2018
@dennismphil dennismphil deleted the datatable branch June 12, 2019 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove compact prop from DataTable
2 participants