Skip to content

Add Object.assign to list of required polyfills #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

jimmydief
Copy link
Contributor

Fixes #1431.

Pull Request Review checklist (do not remove)

  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @jimmydief to sign the Salesforce.com Contributor License Agreement.

@interactivellama
Copy link
Contributor

Thanks. If you ever see one and want to change it to an ES6 object spread .... Babel will polyfill it for you.

@interactivellama interactivellama self-requested a review June 26, 2018 14:44
@interactivellama interactivellama merged commit 4da7d86 into salesforce:master Jun 26, 2018
@jimmydief jimmydief deleted the patch-1 branch June 26, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object.assign is missing from required polyfills
2 participants