Remove object assign #1435
Merged
Remove object assign #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interactivellama
force-pushed
the
remove-object-assign
branch
from
69b6418 to
344cbde
Compare
interactivellama
force-pushed
the
remove-object-assign
branch
from
344cbde to
d052156
Compare
interactivellama
requested review from
futuremint
and removed request for
davidlygagnon
futuremint
reviewed
Jul 6, 2018
| onSelect={(event, data) => { | ||
| console.log('onSelect', data); | ||
| this.setState({ selection: data.selection }); | ||
| }} |
There was a problem hiding this comment.
The removal of this code doesn't look related to Object.assign.
There was a problem hiding this comment.
Thanks. Snapshots don't need events.
futuremint
reviewed
Jul 6, 2018
futuremint
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1434
Additional description
Replaces
object.assignwith ES6 spreadPull Request Review checklist (do not remove)
npm run lint:fixhas been run and linting passes.