Update Tree branch and item to use new SLDS HTML tags #1442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional description
When the Tree component is used for left hand navigation, which is quite often, when the tree gets big and expands to the whole space, when users hover over a item/branch, the link URL is displayed in the lower left hand corner of the browser window (Chrome).
We've seen that if the link element is long or the tree item is short user's can miss the tree item at the bottom of the screen.
To combat this, we are submitting this PR which removes the
href
attr from the Tree's branch and item.After checking W3, we've found the following:
Pull Request Review checklist (do not remove)
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.