Skip to content

add "offset" prop to combobox and update doc #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

add "offset" prop to combobox and update doc #1452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
744c890
add "offset" prop to combobox and update doc
qyiming Jul 11, 2018
b637dd2
make offset an undocumented prop
qyiming Jul 11, 2018
884a5c3
remove offset proptype
qyiming Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/combobox/combobox.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,12 +317,15 @@ class Combobox extends React.Component {
? 'relative'
: this.props.menuPosition; // eslint-disable-line react/prop-types


return !this.props.disabled && this.getIsOpen() ? (
// offset is an undocumented prop and its usage is discouraged.
<Dialog
align="bottom left"
context={this.context}
hasStaticAlignment={this.props.hasStaticAlignment}
inheritWidthOf={this.props.inheritWidthOf}
offset={this.props.offset}
onClose={this.handleClose}
onOpen={this.handleOpen}
onRequestTargetElement={this.getTargetElement}
Expand Down