Skip to content

Prefer object spread eslint rule #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2018
Merged

Prefer object spread eslint rule #1457

merged 1 commit into from
Jul 25, 2018

Conversation

interactivellama
Copy link
Contributor

Add eslint rule to prefer spread operator over Object.assign(). This only gets flagged though when the first parameter is {}.

interactivellama referenced this pull request Jul 13, 2018
@jimmydief
add Object.assign to list of required polyfills
8ec0eb3
@futuremint futuremint self-requested a review July 19, 2018 01:44
@futuremint
Copy link
Contributor

FYI Travis is failing because there is still an Object.assign in https://github.com/salesforce/design-system-react/blob/master/webpack.config.dist.js#L12 😄

@interactivellama
Prefer object spread eslint rule
9eeed70 
# Conflicts:
#	package-lock.json
@interactivellama
Copy link
Contributor Author

Not production code. Merging. Tests pass now.

@interactivellama interactivellama merged commit 8fd3f2b into salesforce:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futuremint futuremint Awaiting requested review from futuremint

Assignees
No one assigned
Labels
maintenance-task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@interactivellama @futuremint