Support developing with React 16, and as a peer dependency #1468
Conversation
Updates patch version of storybook.
futuremint
changed the title
package.json
Outdated
| @@ -113,8 +113,8 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@salesforce-ux/design-system": "^2.6.0", | |||
| "react": ">=15.4.1 <16", | |||
| "react-dom": ">=15.4.1 <16" | |||
| "react": ">=16", | |||
There was a problem hiding this comment.
This should be this way in the devDependencies, but are you sure we shouldn't include 15 since you only changed test code? We could also bump the minor version, too, just to make sure it's clear to consumers even if it's not a breaking change except npm and introduce npm install warnings. We have communicated to teams that we were going to do this after March, but I'm thinking we need to re-iterate it before releasing. What do you think?
There was a problem hiding this comment.
Yes, thanks for catching this. I mean to put it back to including 15.4.1 and above... I'll get this done this afternoon or tomorrow.
|
We will want to update any docs that mention a version. https://github.com/salesforce/design-system-react#getting-started |
|
Thanks, I forgot about the docs, I'll get those updated too. |
…to react-16 # Conflicts: # package-lock.json
Fixes #1282. Note: no code changes to any components were needed for this.
This changes the dev dependency to React 16 as well as the version of ReactDOM, Enzyme, and Test Utils that are being used.
Unit tests and a few older storybook examples have been updated where needed to run with the newer version of React and Enzyme. They also run 50% faster now in the browser (5s vs. 11s in master).
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.REVIEWER checklist (do not remove)
components/component-docs.jsontests.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.