Skip to content

Revert to npm install from npm ci #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2018
Merged

Revert to npm install from npm ci #1471

merged 1 commit into from
Jul 25, 2018

Conversation

interactivellama
Copy link
Contributor

@interactivellama interactivellama commented Jul 25, 2018 •
edited
Loading

Due to TravisCI issues that occur about once a week:

0.49s$ npm ci
npm ERR! Unexpected string in JSON at position 609390
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-07-25T19_59_42_628Z-debug.log
The command "npm ci" failed and exited with 1 during .

REVIEWER checklist (do not remove)

  • TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@interactivellama
Revert to npm install from npm ci
84557a8 
Due to TravisCI issues:

0.49s$ npm ci
npm ERR! Unexpected string in JSON at position 609390
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-07-25T19_59_42_628Z-debug.log
The command "npm ci" failed and exited with 1 during .
@interactivellama
Copy link
Contributor Author

Not production code.

@interactivellama interactivellama merged commit 556710e into salesforce:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance-task test task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@interactivellama