Moved components warning #1489
Merged
Moved components warning #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futuremint
suggested changes
Aug 10, 2018
components/bread-crumb/index.jsx
Outdated
| @@ -3,5 +3,11 @@ | |||
|
|
|||
| // Alias | |||
| import Breadcrumb from '../breadcrumb'; | |||
| import componentHasMoved from '../../utilities/warning/component-has-moved'; | |||
|
|
|||
| componentHasMoved('SLDSBreadCrumb', { | |||
There was a problem hiding this comment.
These should use the component name from ./utilities/constants.js.
interactivellama
force-pushed
the
moved-components
branch
from
ae2fe17 to
b529985
Compare
futuremint
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1418
Additional description
This tells folks when their import paths are pointing to an old alias.
REVIEWER checklist (do not remove)
components/component-docs.jsontests.last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.