SLDSDatePicker bug fix: Fixing issue where year picker doesn't show years correctly #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix console warning showing up when selecting menu item - Set slds-datepicker class on menu item to reuse font size of date picker
| @@ -43,7 +43,7 @@ const DatepickerYearSelector = createReactClass({ | |||
| const opts = []; | |||
|
|
|||
| for (let year = fromYear; year < toYear; year += 1) { | |||
| opts.push({ label: `${year}`, value: year, id: opts.length }); | |||
| opts.push({ label: `${year}`, value: year, id: String(opts.length) }); | |||
There was a problem hiding this comment.
I just saw this today! I didn't catch it when I updated the Combobox props. Thanks
There was a problem hiding this comment.
yup, cool - no worries :)
|
Looks good! |
interactivellama
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1504
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.