Skip to content

Fix CommonJS constant import #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

interactivellama
Copy link
Contributor

@interactivellama interactivellama commented Aug 23, 2018

Fixes #1512

Additional description

Removes all references in library to FORMS_INPUT and NAVIGATION constant strings.

Component display names of old locations (used by CommonJS/ES6 modules transpile export on NPM) of these components result in the following errors.

'../../../utilities/constants' does not contain an export named 'INPUT'.

'../../../utilities/constants' does not contain an export named 'NAVIGATION'.


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Copy link
Contributor

@futuremint futuremint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reviewing the constants file for other missing constants. Looks like TEXTAREA is also missing. This is just manual inspection though... I should write a script that can automate checks like this... 🤔

INPUT and NAVIGATION
CHECKBOX and TEXTAREA imports/exports
@interactivellama
Copy link
Contributor Author

In https://github.com/ExactTarget/fuelux what we did was use call the CommonJS or global version and see if would error out just placing them on the page. We could probably cycle through all the exports of index and place them on a page in production mode and see if they run, but required props would be needed.

Another option would be manually add deprecated component paths (that have moved) to a list.

@interactivellama
Copy link
Contributor Author

@futuremint Updated

@futuremint futuremint merged commit 134ddc1 into salesforce:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NAVIGATION and FORMS_INPUT is undefined
2 participants