Skip to content

Making textarea error & required examples match their SLDS counterparts #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Making textarea error & required examples match their SLDS counterparts #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/textarea/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ exports[`DOM snapshots SLDSTextarea Docs site Error 1`] = `
className="slds-form-element__help"
id="error-1"
>
Error Message
This field is required
</div>
</div>
</div>
Expand Down Expand Up @@ -157,7 +157,7 @@ exports[`DOM snapshots SLDSTextarea Error 1`] = `
className="slds-form-element__help"
id="error-1"
>
Error Message
This field is required
</div>
</div>
</div>
Expand All @@ -171,7 +171,7 @@ exports[`DOM snapshots SLDSTextarea Required 1`] = `
className="slds-form-element"
>
<label
className="slds-form-element__label slds-assistive-text"
className="slds-form-element__label"
htmlFor="text-area-required"
>
<abbr
Expand Down
6 changes: 2 additions & 4 deletions components/textarea/__docs__/storybook-stories.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ storiesOf(TEXTAREA, module)
<Textarea
id="text-area-required"
name="required-textarea"
assistiveText={{
label: 'Textarea Label',
}}
label="Textarea Label"
required
placeholder="Placeholder Text"
/>
Expand All @@ -48,7 +46,7 @@ storiesOf(TEXTAREA, module)
name="required-textarea-error"
label="Textarea Label"
required
errorText="Error Message"
errorText="This field is required"
placeholder="Placeholder Text"
/>
))
Expand Down
2 changes: 1 addition & 1 deletion components/textarea/__examples__/error.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Example extends React.Component {
name="required-textarea-error"
label="Textarea Label"
required
errorText="Error Message"
errorText="This field is required"
placeholder="Placeholder Text"
/>
</IconSettings>
Expand Down