Skip to content

Lookups refactor #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions components/SLDSLookup/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ class SLDSLookup extends React.Component {
if(this.refs.lookup) React.findDOMNode(this.refs.lookup).focus();
}
else if(!prevState.selectedIndex && this.state.selectedIndex){
if(this.refs.clearSelectedItemButton) React.findDOMNode(this.refs.clearSelectedItemButton).focus();
let selectedItem = 'pill-' + this.state.selectedIndex;
if(this.refs[selectedItem]) React.findDOMNode(this.refs[selectedItem]).focus();
}
}

Expand Down Expand Up @@ -141,6 +142,15 @@ class SLDSLookup extends React.Component {
}
}

handlePillKeyDown(event){
if(event.keyCode){
if(event.keyCode === KEYS.DELETE || event.keyCode === KEYS.BACKSPACE){
EventUtil.trapImmediate(event);
this.handleDeleteSelected();
}
}
}

//=================================================
// Rendering Things
renderMenu(){
Expand All @@ -164,41 +174,44 @@ class SLDSLookup extends React.Component {
renderSelectedItem(){
let selectedItem = this.props.items[this.state.selectedIndex].label;
return (
<div className="slds-pill">
<a href="#" className="slds-pill__label">
<a href="#" className="slds-pill" ref={'pill-' + this.state.selectedIndex} onKeyDown={this.handlePillKeyDown.bind(this)}>
<span className="slds-pill__label">
<Icon name={this.props.type} />
{selectedItem}
</a>
</span>
<SLDSButton
label={'Remove ' + selectedItem}
label='Press delete to remove'
variant='icon'
iconName='close'
iconSize='medium'
disabled={true}
onClick={this.handleDeleteSelected.bind(this)}
ref="clearSelectedItemButton"
/>
</div>
</a>
);
}

render(){
let inputClasses = this.state.selectedIndex === null ? 'slds-input':'slds-input slds-hide';
let componentClasses = this.state.selectedIndex === null ? "slds-lookup ignore-react-onclickoutside":"slds-lookup ignore-react-onclickoutside slds-has-selection";
let inputContainerClasses = this.state.selectedIndex === null ? '':' slds-input';
let inputContainerStyle = this.state.selectedIndex === null ? {} : {padding: '5px'};

return (
<div className={componentClasses} data-select="single" data-scope="single" data-typeahead="true">
<div className={componentClasses} data-select="multi" data-scope="single" data-typeahead="true">
<section className="slds-form-element">
<label className="slds-form-element__label" forHTML="lookup">{this.props.label}</label>

<div className="slds-lookup__control slds-input-has-icon slds-input-has-icon--right">
<label className="slds-form-element__label" htmlFor={this.props.type + "Lookup"}>{this.props.label}</label>

<div className={"slds-lookup__control slds-input-has-icon slds-input-has-icon--right" + inputContainerClasses} style={inputContainerStyle}>
{ this.state.selectedIndex !== null ? this.renderSelectedItem() : null }
<InputIcon name="search"/>
<input
id="lookup"
id={this.props.type + "Lookup"}
ref="lookup"
className={inputClasses}
type="text"
aria-label="lookup"
aria-haspopup="true"
aria-autocomplete="list"
aria-activedescendant={this.state.currentFocus ? this.state.currentFocus:""}
Expand Down
6 changes: 4 additions & 2 deletions components/utils/KEYS.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ module.exports = {
UP :38,
RIGHT :39,
DOWN :40,
TAB :9
};
TAB :9,
DELETE :46,
BACKSPACE :8
};