Skip to content

@W-16255012 Fix added for combobox on enter key pressed #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aarthim1111
Copy link
Contributor

Fix added for combobox on enter key pressed same as down key pressed

Copy link

salesforce-cla bot commented Sep 4, 2024

Thanks for the contribution! It looks like @aarthim1111 is an internal user so signing the CLA is not required. However, we need to confirm this.

@aarthim1111
Copy link
Contributor Author

aarthim1111 commented Sep 4, 2024

@ryojiosawa I'm unable to add reviewers here .Can you please review this code ?
This is a change is combobox.jsx where when enter key is pressed, the dialog should be opened and closed .
No other functionality changes.

@interactivellama
Copy link
Contributor

@aarthim1111 Please see if you can sign the CLA

@aarthim1111
Copy link
Contributor Author

@interactivellama I have signed the CLA today
Screenshot 2024-09-17 at 9 48 00 AM

@interactivellama interactivellama merged commit 6962282 into salesforce:master Sep 19, 2024
4 of 5 checks passed
Copy link

welcome bot commented Sep 19, 2024

Congrats on merging your first pull request to Design System React! 🎉
If you have a moment, please fill out this five question survey, we would appreciate it.
On behalf of Salesforce's customers, partners, product specialists and employees, we would like offer sincere thanks and appreciation for helping make our user experience better. We look forward to working with you more in the future.
This definitely calls for a high five! Alt High Five

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants