Add nanoid, remove deprecated shortId

[sanalpanicker]

Fixes #

Additional description

Adding nanoid and removing deprecated shortid

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

• First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
• npm run lint:fix has been run and linting passes.
• Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
• Tests have been added for new props to prevent regressions in the future. See readme.
• Review the appropriate Storybook stories. Open http://localhost:9001/.
• Review tests are passing in the browser. Open http://localhost:8001/.
• Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

• CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
• Tests have been added for new props to prevent regressions in the future. See readme.
• Review the appropriate Storybook stories. Open http://localhost:9001/.
• The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
• Review tests are passing in the browser. Open http://localhost:8001/.
• Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

• Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
• Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
• Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
• While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @sanalpanicker-zz to sign the Salesforce Inc. Contributor License Agreement.

[jaube-litify]

@interactivellama it looks like last time you were able to override the CLA app since @sanalpanicker is a current salesforce employee: #3155 (comment). Is that something you can do here as well?

[interactivellama]

Yes, I'm open to overriding the CLA.

Great workaround solution! @sanalpanicker-zz

There's an error in the tests for Tree.
https://app.circleci.com/pipelines/github/salesforce/design-system-react/639/workflows/cb6c2c03-686e-4f3c-947f-f99778274eae/jobs/2955/parallel-runs/0/steps/0-106

[interactivellama]

@sanalpanicker Great fix!

However, CircleCI isn't working well with the discrepancy of commits.
https://app.circleci.com/pipelines/github/salesforce/design-system-react/643/workflows/6d1af17d-b4dc-4dd9-9a8c-b6d2705b4eb0/jobs/2977/parallel-runs/0/steps/0-101

I pulled down your branch to my local machine via gh pr checkout 3168, and there was only one commit in the branch Add nanoid, remove deprecated shortId. It did not have your second commit present fixing test issues present. I believe Circle CI is having the same problem with checking out this branch.

I do see the second commit here when I pull your branch down with git without the gh cli https://github.com/sanalpanicker/design-system-react/tree/update-nanoid

I'll look into this further, but I wanted to let you know if it's something obvious on your side.

[sanalpanicker]

Thats really weird.
when I run gh pr view 3168 --json commits I can see both the commits

{
  "commits": [
    {
      "authoredDate": "2024-12-19T20:03:45Z",
      "authors": [
        {
          "login": "sanalpanicker-zz",
          "name": "Sanal Panicker"
        }
      ],
      "committedDate": "2024-12-19T20:03:45Z",
      "messageBody": "",
      "messageHeadline": "Add nanoid, remove deprecated shortId",
      "oid": "a67b6d75cdbe8faee8c5bdfbcbc3af1e0c7e97bf"
    },
    {
      "authoredDate": "2025-01-09T01:35:05Z",
      "authors": [
        {
          "login": "sanalpanicker-zz",
          "name": "Sanal Panicker"
        }
      ],
      "committedDate": "2025-01-09T01:35:05Z",
      "messageBody": "",
      "messageHeadline": "fixing test issues",
      "oid": "6c9fdf7772bce75532de2730ff36beb1c6412824"
    }
  ]
}

[interactivellama]

I pushed a new PR and it works with a squashed commit and tests are working. #3170

https://app.circleci.com/pipelines/github/salesforce/design-system-react/644/workflows/db65e6db-bea6-4e1c-89bd-43dd9c068c17/jobs/2991/parallel-runs/0/steps/0-101

Feel free to force push or something like that. I'm still unsure of the reason though. Sorry for the extra work.

[sanalpanicker]

Ah I should have may be just ameded the fix. Thanks!
Closing : Fix in PR