Skip to content

Updates datepicker to have a border, be the proper width. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2016
Merged

Updates datepicker to have a border, be the proper width. #331

merged 1 commit into from
Jun 16, 2016

Conversation

chriscorwin
Copy link
Contributor

screenshot 2016-06-16 11 42 01

Fixes #330.

@tweettypography tweettypography temporarily deployed to design-system-react-com-pr-331 June 16, 2016 15:58 Inactive
@interactivellama
Copy link
Contributor

@donnieberg Do you know if any teams have a need for the datepicker to be the width of the text input it's under? Forcing it to be small seems like the best way to stick with SLDS patterns.

@interactivellama interactivellama self-assigned this Jun 16, 2016
@donnieberg
Copy link
Contributor

@interactivellama No, I don't. And I think forcing it to be small is the best thing for right now unless we propose a 'responsive' design for the datepicker to the SLDS core team.

@interactivellama interactivellama merged commit d9cef40 into salesforce:master Jun 16, 2016
@chriscorwin chriscorwin deleted the GH330---dateinput-has-no-border_-is-too-wide branch July 14, 2016 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
date-picker P1 SLDS-action-needed
Projects
None yet
Milestone
2016.06b-design-system-react
Development

Successfully merging this pull request may close these issues.
4 participants
@chriscorwin @interactivellama @donnieberg @tweettypography