Skip to content

Displays label properly on <SLDSInput> when both label and assistiveText are defined #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2016
Merged

Conversation

iowillhoit
Copy link
Contributor

Fixes #314 and adds tests for

Adds a new warning in utilities/warning that helps prevent defining unneeded props.

@tweettypography tweettypography temporarily deployed to design-system-react-com-pr-337 June 20, 2016 18:06 Inactive
@iowillhoit iowillhoit closed this Jun 20, 2016
@iowillhoit iowillhoit reopened this Jun 20, 2016
@tweettypography tweettypography temporarily deployed to design-system-react-com-pr-337 June 20, 2016 18:33 Inactive
@tweettypography
Copy link
Contributor

Looks great to me! @donnieberg, do you want to review and merge this?

@donnieberg
Copy link
Contributor

donnieberg commented Jun 21, 2016

Looks great! I like this format of when the label is visible, use label and then when the label should be hidden, use assistiveText. Has this been added to the documentation? I'll merge this in but let's definitely add it there if it's not already :)

@donnieberg donnieberg merged commit 74e7506 into salesforce:master Jun 21, 2016
@iowillhoit iowillhoit deleted the input-label branch June 21, 2016 12:24
@donnieberg donnieberg self-assigned this Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants