Skip to content

Remove isRequired for iconCategory in Button. #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2016
Merged

Remove isRequired for iconCategory in Button. #341

merged 1 commit into from
Jun 22, 2016

Conversation

donnieberg
Copy link
Contributor

@donnieberg donnieberg commented Jun 22, 2016

Buttons without icons should not be required to pass in this prop :)

@tweettypography tweettypography temporarily deployed to design-system-react-com-pr-341 June 22, 2016 00:22 Inactive
@iowillhoit iowillhoit merged commit d7d8eba into master Jun 22, 2016
@iowillhoit
Copy link
Contributor

Looks good. It would be nice if there was a way to do conditional requires. "If iconName is set, require iconCategory". I'm a little nervous that people will supply an iconName but not realize that they might need to change the iconCategory from the default (utility) to something else. I suppose we could throw a warning..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants